I I do believe that koi are about the longest living in the hobby, but that's only with a proper pond that isn't ridicoulously overstocked (which almost all koi ponds I've seen are lol)
most cichlids live 10 years or so, plecos it depends if you keep them in proper conditions they can live as long as 30 years this means you need to get them in a large enough aquarium (240g+) or in a pond as they can grow as large as 3 feet long in some variations.
I've heard that some puffers can live as long as 30-40 years
then of course there are the fancy goldfish varieties that live up to 50 years.
typically if you get smaller(1.5-5" adulthood)/cheaper fish from the pet store they live anywhere from 3-5 years (mollies, platies, small gouramis, small tetras, etc)
medium (5-8")/moderate cost 5-7 years (small sharks, medium gouramis, etc)
medium large (5-14")/ moderately expensive 10 years (cichlids, large fresh water sharks, small plecos, etc)
large (14"+) / expensive (or moderate cost in the case of koi and plecos bought as babies) 15-40 years Koi 50-100 years if kept in the family (large plecos, koi, large puffers, most saltwater fish, fancy goldfish (size exception), any of the ancient fish types, etc)